Change IIIF image requests to v3 #4127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdid
force-pushed
the
5044-iiif-3
branch
2 times, most recently
from
9fa66f8
to
a0a7cc7
Compare
kdid
changed the title
mbklein
approved these changes
Aug 28, 2024
app/test/meadow/config_test.exs
Outdated
| @@ -90,15 +90,15 @@ defmodule Meadow.ConfigTest do | |||
| end | |||
|
|
|||
| test "trailing slashes/0" do | |||
| Application.put_env(:meadow, :iiif_server_url, "http://no-slash-test/iiif/2") | |||
| Application.put_env(:meadow, :iiif_server_url, "http://no-slash-test/3") | |||
There was a problem hiding this comment.
Is there a iiif/ missing here? And below?
There was a problem hiding this comment.
Thanks for catching that! Pushed a change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Change the path in our indexed image urls to call the IIIF Image v3 API via our IIIF server.
Specific Changes in this PR
Version bump required by the PR
See Semantic Versioning 2.0.0 for help discerning which is required.
Steps to Test
?as=iiifresponses contain/iiif/3🚀 Deployment Notes
Note - if you check any of these boxes go to the (always open)
main<-stagingPR and add detailed notes and instructions to help out others who may end up deploying your changes to productionmix meadow.pipeline.setuprun)miscellanyTested/Verified